User Pass
Home Sign Up Contact Log In
Forum > Discuss GLB Issues With Catch22 > RESOLVED BUGS > K : energy Undefined and morale undefined - RESOLVED BUG #222
Page:
 
pabst
offline
Link
 
Originally posted by VolBrian
That's part of what makes this issue difficult.

You will need to disable greasemonkey if you're using it in FF. You'll need to switch to the fps replays if you're using the Flash, and then I think they should be viewable only if you have a player on the team whose replays you are viewing. You may have to be a GM or owner, not sure.

That's why Bobmachinegun's screen shot is valuable here.

If you had the right script installed when it was initially implemented, you could see energy/morale levels for every player in every game. Bort has since fixed that little quirk :-(

Players who began a play with less than 10 energy always showed up as undefined. Case in point: http://goallineblitz.com/game/replay.pl?game_id=1283787&pbp_id=2126213
1124923: starts with 8 energy
1684414: starts with 8 energy
1735376: starts with 9 energy
All three are undefined.

replay.js -- line 306: if (showBreath && ty >= 10 && mo >= 10 && $('breath_' + id) && $('morale_' + id)) {

That if statement is a precondition for updating the energy and morale values. Without an energy and morale above 10, they never get updated. I have no clue why those 10's are there, but I'd bet changing those 10's to 1's solves the problem.
 
Hokiemon
offline
Link
 
Passing this one on to QA as a bug. The undefined error shows up instead of a value (when energy/morale is <10 per pabst)


BUG - NEEDS VERIFICATION
 
NiborRis
offline
Link
 
Pabst has done a good job laying out the details here. As I mentioned, there are also cases where the last tick of the play doesn't have all the players in it, and that causes the same problem. I think we have enough to be able to send this to Bort.

Bug, first verification.
 
NiborRis
offline
Link
 
Originally posted by pabst
If you had the right script installed when it was initially implemented, you could see energy/morale levels for every player in every game. Bort has since fixed that little quirk :-(


BTW, that was a bug, not a quirk, which is why we fixed it. Sorry
 
Djmr
offline
Link
 
Originally posted by pabst
That if statement is a precondition for updating the energy and morale values. Without an energy and morale above 10, they never get updated. I have no clue why those 10's are there, but I'd bet changing those 10's to 1's solves the problem.


Tbh I don't even see the need for the >=10 bits, doing either would solve the problem though. Second verification.
 
HouseRules
offline
Link
 
Bug Filed.
 
HouseRules
offline
Link
 
Players cannot have less than 10 breath or morale. This is a situation with a half-frame or some such, where all data is not available. Bort will update the replay to display "?" instead, since the actual data is unknown.
 
pabst
offline
Link
 
Originally posted by lhouse
Players cannot have less than 10 breath or morale. This is a situation with a half-frame or some such, where all data is not available. Bort will update the replay to display "?" instead, since the actual data is unknown.

The data doesn't lie. Three players in the replay I posted have less than 10 breath.

var play_data = [[{id: 'ball',x: 88,y: 149.25,br: 0,mo: 0,z: 4},{id: '922632',x: 90,y: 153.5,br: 0,mo: 0},{id: '883148',x: 84.25,y: 153,br: 0,mo: 0},{id: '465606',x: 96,y: 153,br: 0,mo: 0},{id: '1187441',x: 77,y: 152.25,br: 0,mo: 0},{id: '1422038',x: 103,y: 152.25,br: 0,mo: 0},{id: '1257044',x: 70,y: 152.5,br: 0,mo: 0},{id: '1343385',x: 90,y: 141.5,br: 0,mo: 0},{id: '1208360',x: 90,y: 134.5,br: 0,mo: 0},{id: '771883',x: 135,y: 153.5,br: 0,mo: 0,icon: 'sweat2'},{id: '1289661',x: 45,y: 148.5,br: 0,mo: 0,icon: 'sweat2'},{id: '1184646',x: 90,y: 149.25,br: 0,mo: 0},{id: '1679601',x: 72,y: 159.5,br: 63,mo: 100},{id: '1682591',x: 83,y: 159.5,br: 54,mo: 100},{id: '1157924',x: 95,y: 159.5,br: 41,mo: 100},{id: '1684279',x: 108,y: 159.5,br: 25,mo: 100,icon: 'sweat1'},{id: '1758571',x: 74.75,y: 163.5,br: 38,mo: 100},{id: '1706896',x: 88,y: 165,br: 60,mo: 100},{id: '1689694',x: 101,y: 163,br: 82,mo: 100},{id: '1124923',x: 78.75,y: 183.5,br: 9,mo: 100,icon: 'sweat2'},{id: '1684414',x: 101.25,y: 183.5,br: 8,mo: 96,icon: 'sweat2'},{id: '1222163',x: 135,y: 163.5,br: 12,mo: 100,icon: 'sweat2'},{id: '1735376',x: 45,y: 163.5,br: 9,mo: 100,icon: 'sweat2'}],
Edited by pabst on Aug 15, 2010 18:53:16
 
Catch22
offline
Link
 
Thread locked by moderator.
 
Page:
 


You are not logged in. Please log in if you want to post a reply.